Fix for task removal

[matrix-goal-bot.git] / matrix_goal_bot / db.py

diff --git a/matrix_goal_bot/db.py b/matrix_goal_bot/db.py
index 1e90bcfec3797fa31e0b8b1e66101bbd4b0a5cae..6421d2bdb3aad8141dae7e52d42b2d61872ec084 100644 (file)
--- a/matrix_goal_bot/db.py
+++ b/matrix_goal_bot/db.py
@@ -4,6 +4,7 @@ from datetime import datetime as dt
 
 from sqlmodel import Field, Session, SQLModel, create_engine, select, text, Relationship
 
+logger = logging.getLogger(__name__)
 
 DATE_FORMAT = '%Y-%m-%d'
 
@@ -11,10 +12,6 @@ def today():
     return dt.now().strftime(DATE_FORMAT)
 
 
-logger = logging.getLogger(__name__)
-logging.basicConfig(filename='goals.log', encoding='utf-8', level=logging.DEBUG)
-
-
 class Vision(SQLModel, table=True):
     id: int | None = Field(default=None, primary_key=True)
     name: str = Field(default=None, unique=True)
@@ -70,7 +67,7 @@ def pretty_print(goal, tasks):
 class Data():
     def __init__(self, db_file=None):
         if not db_file:
-            db_file = os.path.join(os.environ.get('MATRIX_DATA_DIR', ''), 'goals.db')
+            db_file = os.path.join(os.environ.get('MATRIX_DATA_DIR', ''), 'goal.db')
 
         self.file = db_file
         self.engine = self.get_engine()
@@ -106,9 +103,6 @@ class Data():
             cmd = select(Vision).where(Vision.complete_date == None)
             return session.exec(cmd).all()
 
-    def print_ophan_tasks(self):
-        pass
-
     def get_all_goals(self):
         '''List all goals'''
         with Session(self.engine) as session:
@@ -200,17 +194,28 @@ class Data():
 
     def quick_add_task(self, name):
         goal_id = self._get_pref_goal_id()
-        return self.add_task(goal_id, name)
-
-    def add_task(self, goal_id, name):
-        self._set_pref_goal_id(goal_id)
-        result = self.add_with_name(Task, name)
+        task_id = self.add_with_name(Task, name)
         with Session(self.engine) as session:
-            cmd = select(Task).where(Task.name == name)
+            cmd = select(Task).where(Task.id == task_id)
             new = session.exec(cmd).first()
             new.goal_id = goal_id
             session.commit()
-        return result
+        return goal_id
+
+    def remove_task(self, task_id):
+        task_name = ''
+        logger.debug(f'Removing task with id {task_id}')
+        with Session(self.engine) as session:
+            cmd = select(Task).where(Task.id  == int(task_id))
+            to_remove = session.exec(cmd).first()
+            if not to_remove:
+                return f'Unable to find task with id {task_id}'
+
+            logger.debug(f'Removing task with name {to_remove.name}')
+            task_name = to_remove.name
+            session.delete(to_remove)
+            session.commit()
+        return f'Removed task "{task_name}"'
 
     def assign_vision(self, goal_id, vision_id):
         '''Goals may move between visions'''